I've had vivid pictures of these guys in my head for a long time now, and I'll do my best to describe them here.
The Admiral
-Closed Red Coat with high golden collar
-White pants, possibly striped
-Golden pocket chain
-Black bicorner hat, gold embroidery, red feather
-Grinning, noble face, perhaps a subtle beard.
-A sword or a flintlock pistol, maybe even a compass or pocket watch
-Gold buttons
-Large knighthood medal on right side, campaign and valour medals on left chest.
The Golfer
-Red polo, perhaps with white stripes and a little gold lion on the left breast
-Khaki shorts or pants, or plaid golf shorts
-A baseball cap or traditional Scottish hat of some sort
-A golf club and ball
-Grinning, perhaps laughing or focused face
The General
-US army style, 40s
-Closed olive green coat, gold leaf embroidered chain
-Many medals
-Coloured squares for rank
-Olive green pants, red stripes on side
-Determined, grey moustached face, stubble, with cigar (if lego doesn't find that too profane )
-Green officer's cap, golden eagle on front
-Baton, or revolver pistol
The Soldier
-Olive green, sweaty coat
-Olive green pants
-3 chevrons on side of arms
-Determined, cleanly shaved face
-Single medal
-Classic 40s style M1 Pot helmet
-Battle rifle or Tommy Gun
(Overall a WW2-Korea-'Nam style american soldier)
The Egyptian Soldier
-Bare tanned chest
-Toga style garment covering legs, part of torso
-Classic style headdress
-Spear or axe for weapon
-Yelling face
(If I forgot anything I'll be sure to add it in)