I wouldn't call that "sharing" if someone sells instructions for money. They do share the photos of their products, just like Apple "shares" photos of their iPhones, but Apple never shared any of their devices with me unless I pay them. Also the community doesn't care, there will always be people sharing photos, instructions and digital files for free. The community will live on. If there are no people sharing anything for free to start with, I wouldn't call that a community, that's a market.
I've published instructions for free myself, and I wouldn't care if I see someone selling them. That's completely in the spirit of open source communities. Even with open source licenses that many companies find quite restrictive like the GPL you are still allowed to sell anything that comes with a GPL license. I could start a business selling Firefox, that would be completely fine. I would just need to find somebody dumb enough to pay for something they can get for free elsewhere...
Now some people say they have expenses and spend effort creating instructions and they want compensation for that. That's okay. Start a crowdfunding campaign and once your expenses are compensated release the instructions for free to the community. Anything else you do is speculating on profit for you. I don't have anything against that either, but I don't see how that benefits the community.
I wouldn't buy anything like that. Don't treat your customers like criminals.